Fix for the compiler path in compile_commands.json file #1138

alicetrifu · 2025-04-10T13:49:54Z

Compiler path was wrongly created when anything was set on the "Prefix" option from "Cross Settings". The code needs to check if anything is set there before creating the default path for the compiler.

github-actions · 2025-04-10T14:13:32Z

Test Results

584 files - 34 584 suites - 34 14m 2s ⏱️ - 22m 28s
9 887 tests - 1 216 9 863 ✅ - 1 096 24 💤 - 120 0 ❌ ±0
9 925 runs - 1 193 9 901 ✅ - 1 075 24 💤 - 118 0 ❌ ±0

Results for commit fec0b2a. ± Comparison against base commit fd06dca.

This pull request removes 1217 and adds 1 tests. Note that renamed tests count towards both.

org.eclipse.cdt.debug.gdbjtag.core.tests.jtagdevice.GDBJtagDeviceContributionTest ‑ testGdbJtagDeviceContribution
org.eclipse.cdt.debug.gdbjtag.core.tests.launch.GDBJtagLaunchTest ‑ testGdbJtagLaunch[gdb]
org.eclipse.cdt.debug.gdbjtag.core.tests.launch.GDBJtagLaunchTest ‑ testGdbJtagLaunch[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithQuotes[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithQuotes[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSpecialSymbols[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSpecialSymbols[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSymbols[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSymbols[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithTabs[gdb]
…

org.eclipse.cdt.managedbuilder.core.tests.CompilationDatabaseGenerationTest ‑ testGetCompilerArgsWithSpacesAndQuotes

♻️ This comment has been updated with latest results.

...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java

jonahgraham

This looks like roughly the correct solution. Just some cleanup and review the caching.

...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java

jonahgraham

This works well in the normal cases, but there are some corner cases that aren't handled well, see the individual comments.

...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java

ghentschke · 2025-09-04T06:57:24Z

@alicetrifu Is this PR still work in progress?

alicetrifu · 2025-09-04T12:16:09Z

Hello @ghentschke ,

This should be done. I see that the logs are not available anymore for this, but the comments should be fixed. I see that meanwhile this got into conflict. Should I fix this?

ghentschke · 2025-09-04T12:20:44Z

Should I fix this?

That would be great. I think we should fix this, since another user has stumbled around this issue. See eclipse-cdt/cdt-lsp#531 (comment)

but the comments should be fixed.

Yes

alicetrifu · 2025-09-04T13:02:42Z

@ghentschke, I have fixed the conflict directly form the Github UI. I hope this is fine. Will wait for the final result of the checks. Thank you!

ghentschke · 2025-09-05T06:25:15Z

There is still a failed unit test. I am not sure if it relates to this PR.
I don't think so, as other lately build PR have same broken unit test.

alicetrifu · 2025-09-05T08:12:21Z

@ghentschke , This does not seem to be related to my PR indeed. But I am not sure why I have the problem with the Licence. I had this in the past as well and @Kummallinen rerun this for me. I think there are some issues with my permissions. Any idea on what I should do next to fix this ? Thank you!

ghentschke · 2025-09-08T06:55:47Z

But I am not sure why I have the problem with the Licence.

I think there is a general problem with the license server at the moment. See eclipse-cdt/cdt-lsp#535 (comment)

alicetrifu · 2025-09-08T09:35:58Z

Thamk you @ghentschke! Do I need to make any additional changes here? Not sure how to fix the failing test since I am sure it's not releated to this PR. Please let me know what you think about the status here. Thank you!

ghentschke · 2025-09-08T09:51:23Z

@jonahgraham Do you have any objections here?

ghentschke · 2025-09-10T06:31:50Z

Hi @alicetrifu ,
I tested this PR on Windows 11 with a cross compiler toolchain and found this issue here:

The = will be not converted correctly as the unicode escape string is used \u003d instead.
Besides that, the compiler call looks like this:

Invoking: Cross G++ Compiler
x86_64-w64-mingw32-g++ -O2 -g -Wall -c -fmessage-length=0 -MMD -MP -MF"MyMakefileProject.d" -MT"MyMakefileProject.o" -o "MyMakefileProject.o" "../MyMakefileProject.cpp"

and this is the compile_commands.json line:

"command": "\"C:/msys64/mingw64/bin/x86_64-w64-mingw32-g++.exe\" -O2 -g -Wall -c -fmessage-length\u003d0 -o /MyMakefileProject.o C:/Users/user/cdt/workspaces/cdt-ws_new/MyMakefileProject/MyMakefileProject.cpp",

I've seen that the -MMD -MP commands are missing. I am not sure if that's relevant.

Compiler path was wrongly created when anything was set on the "Prefix" option from "Cross Settings". The code needs to check if anything is set there before creating the default path for the compiler.

jonahgraham

Re-based on main and re-approved. AFAICT this can be merged once we get a clean build.

@ghentschke

The = will be not converted correctly as the unicode escape string is used \u003d instead.

If this is a problem please raise a new issue/PR for it. If it is an issue it is a sign that the method of escaping used in the writing of compile_commands.json. I suspect it can be resolved by disabling HTML escaping in the GsonBuilder we are using here:

cdt/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java

Line 134 in 7420b12

Gson gson = new GsonBuilder().setPrettyPrinting().create();

I've seen that the -MMD -MP commands are missing. I am not sure if that's relevant.

MMD/MP are dependency generating commands (the ones that create the extra makedfiles) (docs)

I think these are properly excluded. The CompilationDatabaseGenerator is implemented based on the GnuMakefileGenerator and excluding addDependencyOptions seems correct to me.

ghentschke · 2025-10-08T11:20:36Z

If this is a problem please raise a new issue/PR for it. If it is an issue it is a sign that the method of escaping used in the writing of compile_commands.json.

I've to check that

alicetrifu force-pushed the fixPathForCompiler1130 branch from 1151c1e to dabaf25 Compare April 10, 2025 14:34

jonahgraham requested changes Apr 10, 2025

View reviewed changes

...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved

jonahgraham linked an issue Apr 10, 2025 that may be closed by this pull request

CDT fails to generate correct commands in compile_commands.json file #1130

Closed

alicetrifu force-pushed the fixPathForCompiler1130 branch from dabaf25 to 080da79 Compare April 10, 2025 15:11

jonahgraham requested changes Apr 10, 2025

View reviewed changes

alicetrifu force-pushed the fixPathForCompiler1130 branch from 080da79 to d448a14 Compare April 10, 2025 15:57

jonahgraham reviewed Apr 10, 2025

View reviewed changes

...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Show resolved Hide resolved

...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved

alicetrifu force-pushed the fixPathForCompiler1130 branch from d448a14 to 2c4aa3f Compare April 11, 2025 07:41

jonahgraham approved these changes Apr 23, 2025

View reviewed changes

alicetrifu force-pushed the fixPathForCompiler1130 branch from 2c4aa3f to 84316a4 Compare April 24, 2025 09:37

alicetrifu force-pushed the fixPathForCompiler1130 branch 2 times, most recently from d01e65c to 70bd427 Compare May 7, 2025 12:57

ghentschke mentioned this pull request Sep 4, 2025

Multiple compile_commands.json for every project build configuration eclipse-cdt/cdt-lsp#531

Open

ghentschke mentioned this pull request Oct 4, 2025

Build using compile_commands.json to automatically assign language for discovered sources #1321

Open

Fix for the compiler path in compile_commands.json file

fec0b2a

Compiler path was wrongly created when anything was set on the "Prefix" option from "Cross Settings". The code needs to check if anything is set there before creating the default path for the compiler.

jonahgraham force-pushed the fixPathForCompiler1130 branch from cfea01e to fec0b2a Compare October 8, 2025 10:49

jonahgraham approved these changes Oct 8, 2025

View reviewed changes

jonahgraham added this to the 12.3.0 milestone Oct 8, 2025

jonahgraham merged commit c6feff5 into eclipse-cdt:main Oct 8, 2025
5 checks passed

Fix for the compiler path in compile_commands.json file #1138

Fix for the compiler path in compile_commands.json file #1138

Uh oh!

Conversation

alicetrifu commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

jonahgraham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonahgraham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghentschke commented Sep 4, 2025

Uh oh!

alicetrifu commented Sep 4, 2025

Uh oh!

ghentschke commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alicetrifu commented Sep 4, 2025

Uh oh!

ghentschke commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alicetrifu commented Sep 5, 2025

Uh oh!

ghentschke commented Sep 8, 2025

Uh oh!

alicetrifu commented Sep 8, 2025

Uh oh!

ghentschke commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghentschke commented Sep 10, 2025

Uh oh!

jonahgraham left a comment

Choose a reason for hiding this comment

Uh oh!

ghentschke commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 10, 2025 •

edited

Loading

ghentschke commented Sep 4, 2025 •

edited

Loading

ghentschke commented Sep 5, 2025 •

edited

Loading

ghentschke commented Sep 8, 2025 •

edited

Loading